Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Fix spaces on the 'Shared via link'-page #7651

Merged
merged 5 commits into from
Sep 20, 2022
Merged

[full-ci] Fix spaces on the 'Shared via link'-page #7651

merged 5 commits into from
Sep 20, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

Spaces on the "Shared via link"-page are now being displayed correctly. Also, the sidebar for those has been fixed.

Related Issue

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Sep 16, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Sep 16, 2022 •
edited
Loading

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/28408/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L133.png

webUISharingPublicManagement-shareByPublicLink_feature-L133.png

webUISharingPublicManagement-shareByPublicLink_feature-L162.png

webUISharingPublicManagement-shareByPublicLink_feature-L162.png

webUISharingPublicManagement-shareByPublicLink_feature-L49.png

webUISharingPublicManagement-shareByPublicLink_feature-L49.png

@JammingBen JammingBen changed the title Fix spaces on the 'Shared via link'-page [full-ci] Fix spaces on the 'Shared via link'-page Sep 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

21.6% 21.6% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review September 19, 2022 11:06
kulmann
kulmann approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit c703afe into master Sep 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-spaces-shared-via-link branch September 20, 2022 08:54
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

link-share of a project space root has no resource name in file list
3 participants
@JammingBen @ownclouders @kulmann